Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noisiness of pre-commit.ci autoupdates #1223

Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

This PR sets the pre-commit.ci autoupdate schedule setting to the maximum value 'quarterly'. The goal is to limit the amount of noisy PRs, such as #1222.

Assumptions

By default, pre-commit.ci performs weekly autoupdate runs that create PRs. Our pre-commit configuration is partially derived from upstream and needs to remain in sync. As a result, these PRs are routinely closed. It is currently impossible to deactivate pre-commit.ci autoupdate, but the schedule setting recently became configurable.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Oct 28, 2024
@jakob-keller jakob-keller marked this pull request as ready for review October 28, 2024 22:11
@jakob-keller jakob-keller force-pushed the pre-commit-ci-autoupdate-schedule branch from 18b7409 to f89ebe9 Compare October 28, 2024 22:18
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (a2b1b68) to head (f89ebe9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
- Coverage   86.35%   86.33%   -0.02%     
==========================================
  Files          64       64              
  Lines        5986     5986              
==========================================
- Hits         5169     5168       -1     
- Misses        817      818       +1     
Flag Coverage Δ
unittests 86.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit ce3f82f into aio-libs:master Oct 28, 2024
11 checks passed
@jakob-keller jakob-keller deleted the pre-commit-ci-autoupdate-schedule branch October 28, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant