Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools dev dependency #1179

Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Remove all remaining occurrences of setuptools / setup.py in the 'development space'.

Assumptions

  • twine check --strict in CI is adequate replacement for setup.py check
  • setuptools is still used as build backend, as specified in pyproject.toml

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Aug 23, 2024
@jakob-keller jakob-keller self-assigned this Aug 23, 2024
@jakob-keller jakob-keller force-pushed the remove-setuptools-dev-dependency branch from f7bc61a to 9b7cfef Compare August 23, 2024 09:30
@jakob-keller jakob-keller mentioned this pull request Aug 23, 2024
13 tasks
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (c9ec197) to head (0f84577).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   86.94%   86.99%   +0.05%     
==========================================
  Files          64       64              
  Lines        5983     5983              
==========================================
+ Hits         5202     5205       +3     
+ Misses        781      778       -3     
Flag Coverage Δ
unittests 86.99% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller force-pushed the remove-setuptools-dev-dependency branch from 9b7cfef to 0f84577 Compare August 23, 2024 09:52
Makefile Show resolved Hide resolved
@jakob-keller jakob-keller merged commit 96781a2 into aio-libs:master Aug 23, 2024
11 checks passed
@jakob-keller jakob-keller deleted the remove-setuptools-dev-dependency branch August 23, 2024 10:34
@jakob-keller jakob-keller mentioned this pull request Aug 23, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants