This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
I think I found a fix for ConnectionResetError bug #1429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thanks for the amazing library, I recently encountered ConnectionResetError bug and found #778 .
so I tried to make a fix.
#778 (comment)
I tested with above code (provided by Enchufa2), this change fixes the problem :)
What do these changes do?
now
Redis.execute_command()
catchesConnectionAbort
and retry execution.Are there changes in behavior for the user?
users do not have to except ConnectionError everytime they execute a command. Since RedisClient catches it for them.
Related issue number
#778
Checklist
I'm trying to add an unit test! please wait a moment :)
if this change looks good for you, I'll also add myself to
CONTRIBUTORS.txt
let me know what you think!
CONTRIBUTORS.txt
<Name> <Surname>
.CHANGES/
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.