Skip to content

Commit

Permalink
notes
Browse files Browse the repository at this point in the history
  • Loading branch information
ainghazal committed Jan 15, 2024
1 parent e7eec22 commit 2d770b6
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion internal/reliabletransport/reliabletransport.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,15 @@ import (
// the channels before invoking [Service.StartWorkers].
type Service struct {
// DataOrControlToMuxer is a shared channel that moves packets down to the muxer

DataOrControlToMuxer *chan *model.Packet

// ControlToReliable moves packets down to us
ControlToReliable chan *model.Packet

// MuxerToReliable moves packets up to us
MuxerToReliable chan *model.Packet

// ReliableToControl moves packets up from us to the control layer above
ReliableToControl *chan *model.Packet
}
Expand Down Expand Up @@ -168,7 +172,7 @@ func (ws *workersState) maybeACK(packet *model.Packet) error {
// currently we are ACKing every packet
// TODO: implement better ACKing strategy

// this function will fail if we won't know the remote session ID
// this function will fail if we don't know the remote session ID
ACK, err := ws.sessionManager.NewACKForPacket(packet)
if err != nil {
return err
Expand Down

0 comments on commit 2d770b6

Please sign in to comment.