Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add ability to define properties on Container subclasses #2966

Merged
merged 9 commits into from
Sep 5, 2023

Conversation

alberttorosyan
Copy link
Member

Support for ORM-like properties definition:

class Run(Container):
  name = Property()
  archived = Property(default=False)

would result to creation of name and archived attributes for Run instances, as well as handle serialization/deserialization in rocksdb.

On the UI SDK side, while parsing the API call result stream, a special keyword $property is used to determine the list of properties. These properties can be accessed as attributes, similar to the Python SDK.

Copy link
Contributor

@mihran113 mihran113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments, other than that looks great

@alberttorosyan alberttorosyan merged commit 57c360d into main Sep 5, 2023
2 of 3 checks passed
@alberttorosyan alberttorosyan deleted the feature/ability-to-define-container-properties branch September 5, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants