[feat] Update Aim ML adapters #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamohannes
suggested changes
Sep 1, 2023
There was a problem hiding this comment.
Seems like we need to update all docstrings, e.g. remove capture_terminal_logs.
Shall we add these two blocks inside of the Run, they seem to be appearing in every adapter.
if self.experiment_name is not None:
self._run.experiment = self.experiment_name
if self.log_system_params:
self._run.enable_system_monitoring()
The rest lgtm!
| @@ -84,7 +67,6 @@ def metrics( | |||
|
|
|||
| def close(self) -> None: | |||
| if self._run: | |||
| self._run.close() | |||
There was a problem hiding this comment.
Why this line is removed? Will it be enough to just delet or set the run instance to None?
There was a problem hiding this comment.
yes, it should be enough. once the ref. count for Run (Container) goes to zero, the ContainerAutoClean should do the cleanup.
tamohannes
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.