Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add methods for sequence and container delete #2946

Merged
merged 3 commits into from
Aug 4, 2023
Merged

[feat] Add methods for sequence and container delete #2946

merged 3 commits into from
Aug 4, 2023

Conversation

mihran113
Copy link
Contributor

No description provided.

alberttorosyan
alberttorosyan reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments/questions.

src/python/aim/_sdk/collections.py Outdated Show resolved Hide resolved
src/python/aim/_sdk/sequence.py Show resolved Hide resolved
src/python/aim/_sdk/container.py Show resolved Hide resolved
alberttorosyan
alberttorosyan approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihran113 mihran113 merged commit a4e6bc1 into main Aug 4, 2023
2 of 3 checks passed
@mihran113 mihran113 deleted the feature/sequences-sdk branch August 4, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alberttorosyan alberttorosyan alberttorosyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihran113 @alberttorosyan