Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online optimization for Agents #172

Merged
merged 29 commits into from
Sep 4, 2023

Conversation

maypink
Copy link
Collaborator

@maypink maypink commented Aug 21, 2023

Minor fixes related to MetaAutoML launches

@maypink maypink linked an issue Aug 21, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #172 (ff62950) into main (3139bfa) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   74.13%   74.12%   -0.01%     
==========================================
  Files         129      129              
  Lines        7678     7688      +10     
==========================================
+ Hits         5692     5699       +7     
- Misses       1986     1989       +3     
Files Changed Coverage Δ
...olem/core/optimisers/genetic/operators/mutation.py 89.21% <0.00%> (-1.79%) ⬇️
...misers/adaptive/mab_agents/contextual_mab_agent.py 31.66% <11.11%> (-0.54%) ⬇️
.../core/optimisers/genetic/operators/reproduction.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Comment on lines 98 to 99
if context.ndim == 2:
context = context[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как думаешь, можно ли это заменить на context = np.array(context).flatten()? Просто я в другом своем пр именно так эту проблему решила, вот теперь думаю как смержить)

https://github.com/aimclub/GOLEM/pull/179/files#diff-c7a030323240627a2724854fd0a1ade3380d2fb06ab7a645305784ca2a2c2733R98-R99

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

йес, давай так

@aim-pep8-bot
Copy link
Collaborator

aim-pep8-bot commented Sep 4, 2023

Hello @maypink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-09-04 13:02:26 UTC

@maypink maypink force-pushed the 171-make-online-learning-possible-for-mab branch from ff62950 to 0865df0 Compare September 4, 2023 13:02
@maypink maypink merged commit d5d1dfa into main Sep 4, 2023
5 checks passed
@maypink maypink deleted the 171-make-online-learning-possible-for-mab branch September 4, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make online learning possible for MAB
4 participants