Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDOT integration test fix #161

Closed
wants to merge 2 commits into from
Closed

Conversation

maypink
Copy link
Collaborator

@maypink maypink commented Aug 7, 2023

This issue can be resolved with types fixes in GOLEM.
The problem was in types of population before and after mutation: so if one Individual was submitted to the entrance, then the Individual must be returned, otherwise the PopulationT must be returned

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #161 (96f3961) into main (cf4f45f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   73.98%   73.97%   -0.02%     
==========================================
  Files         129      129              
  Lines        7658     7658              
==========================================
- Hits         5666     5665       -1     
- Misses       1992     1993       +1     
Files Changed Coverage Δ
...olem/core/optimisers/genetic/operators/mutation.py 91.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@nicl-nno nicl-nno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Думаю такой фикс в любом случае полезен как обработка граничных ситуаций.

@maypink
Copy link
Collaborator Author

maypink commented Sep 1, 2023

Close since @gkirgizov have already merged the same PR

@maypink maypink closed this Sep 1, 2023
@maypink maypink deleted the fedot-integration-test-fix branch September 12, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants