Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix networkx adapter #160

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Fix networkx adapter #160

merged 4 commits into from
Aug 4, 2023

Conversation

YamLyubov
Copy link
Collaborator

@YamLyubov YamLyubov commented Aug 4, 2023

BaseNetworkxAdapter refactored to process parameters of graph nodes correctly.

Also:

  • adapter now can restore a list of OptGraphs
  • OptunaTuner saves study (g.e. to use it for visualisations via optuna)

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #160 (aec8c8d) into main (533ab80) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   73.95%   73.99%   +0.04%     
==========================================
  Files         129      129              
  Lines        7647     7656       +9     
==========================================
+ Hits         5655     5665      +10     
+ Misses       1992     1991       -1     
Files Changed Coverage Δ
golem/core/adapter/adapter.py 90.00% <100.00%> (+0.25%) ⬆️
golem/core/adapter/nx_adapter.py 81.96% <100.00%> (+1.61%) ⬆️
golem/core/tuning/optuna_tuner.py 92.85% <100.00%> (+0.08%) ⬆️
golem/core/tuning/tuner_interface.py 90.67% <100.00%> (+0.07%) ⬆️

... and 3 files with indirect coverage changes

@YamLyubov YamLyubov requested review from gkirgizov and removed request for gkirgizov August 4, 2023 09:49
gkirgizov
gkirgizov approved these changes Aug 4, 2023
@YamLyubov YamLyubov merged commit cf4f45f into main Aug 4, 2023
5 checks passed
@YamLyubov YamLyubov deleted the fix-adapter branch August 4, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants