Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node_depth #152

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Fix node_depth #152

merged 2 commits into from
Jul 24, 2023

Conversation

YamLyubov
Copy link
Collaborator

Node depth was not working correctly for graphs with the following structure (decompose node in FEDOT)
image

Also update_node was not working correctly because only adding node to self._nodes does not add nodes predecessors to graph.nodes

@YamLyubov YamLyubov requested a review from gkirgizov July 20, 2023 18:57
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #152 (f46f1a7) into main (9f8dfcd) will increase coverage by 0.14%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   73.84%   73.98%   +0.14%     
==========================================
  Files         129      129              
  Lines        7634     7649      +15     
==========================================
+ Hits         5637     5659      +22     
+ Misses       1997     1990       -7     
Impacted Files Coverage Δ
golem/core/dag/graph_utils.py 97.29% <96.55%> (-0.62%) ⬇️
golem/core/dag/linked_graph.py 98.62% <100.00%> (ø)

... and 1 file with indirect coverage changes

@YamLyubov YamLyubov merged commit 123a9d8 into main Jul 24, 2023
5 checks passed
@YamLyubov YamLyubov deleted the fix-node-depth branch July 24, 2023 12:12
YamLyubov added a commit that referenced this pull request Jul 25, 2023
* Fix node_depth

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants