Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of dask and speedup pip installation #167

Closed
wants to merge 43 commits into from

Conversation

technocreep
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 54.78036% with 175 lines in your changes missing coverage. Please review.

Project coverage is 64.99%. Comparing base (25f5497) to head (455204b).

Files with missing lines Patch % Lines
fedot_ind/core/repository/dask_models.py 29.47% 67 Missing ⚠️
...tory/industrial_implementations/ml_optimisation.py 38.09% 65 Missing ⚠️
fedot_ind/core/repository/IndustrialDispatcher.py 26.66% 11 Missing ⚠️
fedot_ind/api/main.py 82.35% 6 Missing ⚠️
...d/core/repository/initializer_industrial_models.py 77.27% 5 Missing ⚠️
fedot_ind/core/ensemble/kernel_ensemble.py 50.00% 4 Missing ⚠️
fedot_ind/core/metrics/metrics_implementation.py 42.85% 4 Missing ⚠️
fedot_ind/api/utils/industrial_strategy.py 0.00% 3 Missing ⚠️
fedot_ind/core/models/base_extractor.py 75.00% 3 Missing ⚠️
fedot_ind/api/utils/api_init.py 94.73% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   65.98%   64.99%   -1.00%     
==========================================
  Files         119      121       +2     
  Lines       11977    12186     +209     
==========================================
+ Hits         7903     7920      +17     
- Misses       4074     4266     +192     
Flag Coverage Δ
unittests 64.99% <54.78%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Nov 6, 2024

Thanks for update, @technocreep!

Line 77:74: W503 line break before binary operator

Line 17:1: F811 redefinition of unused 'np' from line 4
Line 93:73: W503 line break before binary operator
Line 530:28: W503 line break before binary operator

Line 13:1: F403 'from fedot_ind.core.metrics.metrics_implementation import *' used; unable to detect undefined names
Line 25:32: F405 'Optional' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 25:41: F405 'OperationParameters' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 46:41: F405 'pd' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 53:20: F405 'pd' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 55:20: F405 'pd' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 57:52: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 67:28: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 70:28: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 83:39: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 87:19: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 87:28: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 88:19: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 88:28: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 91:51: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 91:91: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 97:53: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 120:54: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 155:66: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 158:51: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 159:38: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 160:20: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation

Line 38:5: E704 multiple statements on one line (def)
Line 58:5: E704 multiple statements on one line (def)
Line 87:5: E704 multiple statements on one line (def)

Line 196:121: E501 line too long (125 > 120 characters)

Line 62:9: E704 multiple statements on one line (def)
Line 64:9: E704 multiple statements on one line (def)

Line 22:121: E501 line too long (121 > 120 characters)

Line 87:86: E231 missing whitespace after ','

Line 11:1: F403 'from fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations import *' used; unable to detect undefined names
Line 97:20: F405 'ScalingImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 98:26: F405 'NormalizationImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 100:30: F405 'ImputationImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 102:23: F405 'KernelPCAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 103:16: F405 'PCAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 242:19: W503 line break before binary operator

Line 337:25: F841 local variable 'class_label_list' is assigned to but never used
Line 522:53: W503 line break before binary operator
Line 533:53: W503 line break before binary operator
Line 573:53: W503 line break before binary operator

Comment last updated at 2024-11-29 12:35:37 UTC

@@ -83,7 +83,7 @@ def metric(self) -> float:
return mean_squared_error(
y_true=self.target,
y_pred=self.predicted_labels,
squared=False)
squared=False) ** 0.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в данном случае не то считается, по-моему

Suggested change
squared=False) ** 0.5
squared=True) ** 0.5

или

Suggested change
squared=False) ** 0.5
squared=False)

или можно использовать root_mean_squared_error, потому что параметр squared является deprecated в версиях старше scikit-learn==1.4

@v1docq v1docq closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants