-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweep: Add unit tests for SSAForecasterImplementation #153
Conversation
Thanks for update, @sweep-ai[bot]! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-06-13 11:59:52 UTC |
Sweep: PR ReviewAuthor: sweep-ai[bot] Sweep found Sweep has left comments on the pull request for you to review.
|
target=time_series, |
View Diff
|
||
missing_values_ts = np.array([1, 2, np.nan, 4, 5]) | ||
missing_values_input_data = InputData(idx=np.arange(5), features=missing_values_ts, target=missing_values_ts, task=None) | ||
predicted_values = forecaster.predict_for_fit(missing_values_input_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test_predict_for_fit_edge_cases
method does not verify the correctness of the output when handling missing values in the time series.
FAILED tests/unit/core/models/test_ssa_forecaster.py::TestSSAForecasterImplementation::test_fit - TypeError: init() missing 1 required positional argument: 'data_type' |
Purpose
This pull request adds unit tests for the
SSAForecasterImplementation
class located in thefedot_ind.core.models.ts_forecasting.ssa_forecaster
module. The tests cover most edge cases and ensure the correct behavior of the forecaster.Description
The changes in this pull request include:
test_ssa_forecaster.py
in thetests/unit/core/models
directory.SSAForecasterImplementation
class with default and custom parameters.predict()
andpredict_for_fit()
methods of the forecaster, including handling of simple and complex time series, as well as edge cases like empty input data and missing values.fit()
method.Summary
tests/unit/core/models/test_ssa_forecaster.py
SSAForecasterImplementation
class initialization with default and custom parameterspredict()
andpredict_for_fit()
methods, covering simple and complex time series, as well as edge casesfit()
methodFixes #152.
Tip
To get Sweep to edit this pull request, you can:
This is an automated message generated by Sweep AI.