Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomized model impovements #1232

Closed
wants to merge 22 commits into from
Closed

Atomized model impovements #1232

wants to merge 22 commits into from

Conversation

kasyanovse
Copy link
Collaborator

@kasyanovse kasyanovse commented Dec 18, 2023

  1. Fix some bugs with AtomizedModel
  2. Add wrapper for mutations that allows mutation work with AtomizedModel.pipeline (only for ts_forecasting, will be fixed in next PR)
  3. Switch off RANSAC models due to unstability in tests (randomly return empty result)

Next PR with some new features based on AtomizedModel: #1227

@kasyanovse kasyanovse added the enhancement New feature or request label Dec 18, 2023
@kasyanovse kasyanovse self-assigned this Dec 18, 2023
@pep8speaks
Copy link

pep8speaks commented Dec 18, 2023

Hello @kasyanovse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 15:34: F821 undefined name 'Pipeline'
Line 27:92: F821 undefined name 'Pipeline'
Line 33:35: F821 undefined name 'Pipeline'
Line 44:43: F821 undefined name 'Pipeline'
Line 51:36: F821 undefined name 'MetricCallable'
Line 75:76: F821 undefined name 'PipelineNode'

Comment last updated at 2023-12-19 07:44:25 UTC

@kasyanovse kasyanovse changed the title Atomized impovements Atomized model impovements Dec 18, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (299ffba) 79.47% compared to head (842771c) 79.47%.

Files Patch % Lines
fedot/core/pipelines/node.py 73.33% 4 Missing ⚠️
...t/core/operations/atomized_model/atomized_model.py 40.00% 3 Missing ⚠️
...edot/core/optimisers/genetic_operators/mutation.py 96.07% 2 Missing ⚠️
fedot/core/pipelines/adapters.py 83.33% 2 Missing ⚠️
...ore/operations/atomized_model/atomized_template.py 0.00% 1 Missing ⚠️
fedot/core/pipelines/template.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1232   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files         145      146    +1     
  Lines        9928     9994   +66     
=======================================
+ Hits         7890     7943   +53     
- Misses       2038     2051   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kasyanovse kasyanovse marked this pull request as ready for review December 19, 2023 07:50
@kasyanovse kasyanovse closed this Dec 19, 2023
@kasyanovse kasyanovse deleted the atomized-impovements branch December 19, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants