Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Filling gaps #78

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Feature: Filling gaps #78

merged 5 commits into from
Aug 15, 2023

Conversation

Roman223
Copy link
Collaborator

New feature allows filling NaNs with values sampled from bn.

New flag for managing filter's for neg vals behavior.

@Roman223 Roman223 added enhancement New feature or request test labels Aug 15, 2023
@Roman223 Roman223 self-assigned this Aug 15, 2023
@Roman223 Roman223 linked an issue Aug 15, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #78 (7c60262) into master (2bfca54) will increase coverage by 0.16%.
Report is 2 commits behind head on master.
The diff coverage is 57.41%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   66.93%   67.09%   +0.16%     
==========================================
  Files          39       41       +2     
  Lines        2658     2826     +168     
==========================================
+ Hits         1779     1896     +117     
- Misses        879      930      +51     
Files Changed Coverage Δ
bamt/builders/evo_builder.py 97.33% <ø> (ø)
bamt/display/display.py 23.75% <23.75%> (ø)
bamt/networks/base.py 50.83% <37.50%> (+1.78%) ⬆️
bamt/display/__init__.py 60.00% <60.00%> (ø)
bamt/nodes/base.py 69.76% <66.66%> (-0.24%) ⬇️
bamt/nodes/mixture_gaussian_node.py 78.87% <70.00%> (+1.26%) ⬆️
bamt/nodes/conditional_mixture_gaussian_node.py 87.03% <72.72%> (+0.62%) ⬆️
bamt/nodes/gaussian_node.py 82.85% <85.71%> (+0.76%) ⬆️
bamt/nodes/logit_node.py 85.07% <85.71%> (-0.64%) ⬇️
bamt/nodes/discrete_node.py 95.23% <88.88%> (-4.77%) ⬇️
... and 5 more

... and 1 file with indirect coverage changes

@Roman223 Roman223 marked this pull request as ready for review August 15, 2023 11:54
jrzkaminski
jrzkaminski previously approved these changes Aug 15, 2023
@jrzkaminski jrzkaminski merged commit 43fba0f into master Aug 15, 2023
4 checks passed
@Roman223 Roman223 deleted the fill_gaps branch October 26, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated Data Strings
4 participants