Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyitlib elimination #70

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Pyitlib elimination #70

merged 5 commits into from
Aug 1, 2023

Conversation

Roman223
Copy link
Collaborator

@Roman223 Roman223 commented Jul 31, 2023

Package conflict
Pyitlib requires scikit-learn lower than 1.0.0.
The problem is that old versions have troubles with Cython on some machines and we decided to move pyitlib into external and import it as a build-in package bypassing pip installation. It turns out that part we need contains the only one object from sklearn - LabelEncoder, which is stable across mostly versions.

Tests imrovements
Sometimes pickle compression works and a test returns error. This case was covered.

Code formatted to black style as well.

@Roman223 Roman223 added bug Something isn't working dependencies Pull requests that update a dependency file test labels Jul 31, 2023
jrzkaminski
jrzkaminski previously approved these changes Jul 31, 2023
serialization sign changed to correct one
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #70 (2580ede) into master (7e11513) will increase coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   65.11%   65.15%   +0.04%     
==========================================
  Files          32       32              
  Lines        2250     2250              
==========================================
+ Hits         1465     1466       +1     
+ Misses        785      784       -1     
Files Changed Coverage Δ
bamt/networks/base.py 48.62% <33.33%> (ø)

... and 5 files with indirect coverage changes

@jrzkaminski jrzkaminski merged commit 4f7fe72 into master Aug 1, 2023
4 checks passed
@Roman223 Roman223 deleted the pyitlib_elimination branch August 11, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants