Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package conflict
Pyitlib requires
scikit-learn
lower than 1.0.0.The problem is that old versions have troubles with
Cython
on some machines and we decided to movepyitlib
into external and import it as a build-in package bypassingpip
installation. It turns out that part we need contains the only one object from sklearn -LabelEncoder
, which is stable across mostly versions.Tests imrovements
Sometimes pickle compression works and a test returns error. This case was covered.
Code formatted to black style as well.