-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Align citation and acknowledgements with AIM RSF guidelines #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 22, 2024
RayStick
reviewed
Oct 22, 2024
RayStick
reviewed
Oct 24, 2024
RayStick
reviewed
Oct 24, 2024
RayStick
reviewed
Oct 24, 2024
Co-authored-by: Rachael Stickland <[email protected]>
Co-authored-by: Rachael Stickland <[email protected]>
Co-authored-by: Rachael Stickland <[email protected]>
…seMetadata into BatoolMM-authorship
…seMetadata into BatoolMM-authorship
RayStick
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Batool - looks great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #131
This PR to align citation and acknowledgements with AIM RSF guidelines. I think the citation of the package can be different from how each version is archived in Zenodo. I am happy to keep your name in the desc - I think this is the norm in open source, no need to add a maintainer or other contributors.
Checklist before review:
devtools::check()
returns no errors or warnings.