Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Align citation and acknowledgements with AIM RSF guidelines #135

Merged
merged 13 commits into from
Oct 24, 2024

Conversation

BatoolMM
Copy link
Member

@BatoolMM BatoolMM commented Oct 22, 2024

Fix #131

This PR to align citation and acknowledgements with AIM RSF guidelines. I think the citation of the package can be different from how each version is archived in Zenodo. I am happy to keep your name in the desc - I think this is the norm in open source, no need to add a maintainer or other contributors.

Checklist before review:

  • Please comment on my PR while it's a draft and give me feedback on the development!
  • I added everything I wanted to add to this PR, please review!
  • [if package files were edited] Running devtools::check() returns no errors or warnings.
  • The code base and the documentation match (they both reflect any recent changes).
  • The title of this PR is clear and self-explantory.
  • I added any appropriate labels to this PR.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 22, 2024
README.md Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
inst/CITATION Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@RayStick RayStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Batool - looks great

@RayStick RayStick merged commit 645a5a9 into main Oct 24, 2024
2 checks passed
@RayStick RayStick deleted the BatoolMM-authorship branch October 24, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check citation and acknowledgements
2 participants