-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow triggering pr-review from forked repo #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
pat-to-preview
branch
from
December 18, 2023 23:31
e76a1a5
to
8050d29
Compare
unkcpz
force-pushed
the
pat-to-preview
branch
from
December 18, 2023 23:36
8050d29
to
1c34d32
Compare
unkcpz
force-pushed
the
pat-to-preview
branch
from
December 19, 2023 00:05
1c34d32
to
2ea6714
Compare
unkcpz
changed the title
pr-review from forked repo
Allow triggering pr-review from forked repo
Dec 19, 2023
unkcpz
added a commit
that referenced
this pull request
Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes. The `pull_request_target` replaces the `pull_requests` event to limit the preview trigger condition to avoid malicious preview trigger actions.
unkcpz
added a commit
to unkcpz/aiida-registry
that referenced
this pull request
Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes.
unkcpz
added a commit
that referenced
this pull request
Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes. The pull_request_target replace pull_request to use the correct permission and to avoid malicious code injection to CI.
unkcpz
added a commit
that referenced
this pull request
Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes. The pull_request_target replace pull_request to use the correct permission and to avoid malicious code injection to CI.
unkcpz
added a commit
that referenced
this pull request
Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes. The pull_request_target replace pull_request to use the correct permission and to avoid malicious code injection to CI.
unkcpz
added a commit
that referenced
this pull request
Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes. The pull_request_target replace pull_request to use the correct permission and to avoid malicious code injection to CI.
unkcpz
added a commit
that referenced
this pull request
Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes. The pull_request_target replace pull_request to use the correct permission and to avoid malicious code injection to CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #272 to allow pr-preview from forked repo.