Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow triggering pr-review from forked repo #296

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 18, 2023

fixes #272 to allow pr-preview from forked repo.

@unkcpz unkcpz merged commit f283379 into aiidateam:master Dec 19, 2023
@unkcpz unkcpz changed the title pr-review from forked repo Allow triggering pr-review from forked repo Dec 19, 2023
unkcpz added a commit that referenced this pull request Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes.
The `pull_request_target` replaces the `pull_requests` event to limit the preview trigger condition to avoid malicious preview trigger actions.
unkcpz added a commit to unkcpz/aiida-registry that referenced this pull request Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes.
unkcpz added a commit that referenced this pull request Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes.
The pull_request_target replace pull_request to use the correct
permission and to avoid malicious code injection to CI.
unkcpz added a commit that referenced this pull request Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes.
The pull_request_target replace pull_request to use the correct
permission and to avoid malicious code injection to CI.
unkcpz added a commit that referenced this pull request Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes.
The pull_request_target replace pull_request to use the correct
permission and to avoid malicious code injection to CI.
unkcpz added a commit that referenced this pull request Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes.
The pull_request_target replace pull_request to use the correct
permission and to avoid malicious code injection to CI.
unkcpz added a commit that referenced this pull request Dec 19, 2023
This change should make it possible to show pr-preview by PR from the forked repo, and set the `paths` parameters to `plugins.yaml` so it only can be triggered when this file changes.
The pull_request_target replace pull_request to use the correct
permission and to avoid malicious code injection to CI.
@unkcpz unkcpz deleted the pat-to-preview branch December 19, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pr-preview-action when the new version 2 is released
1 participant