Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pr-preview-action when the new version 2 is released #272

Closed
AhmedBasem20 opened this issue Sep 14, 2023 · 1 comment · Fixed by #296
Closed

Update pr-preview-action when the new version 2 is released #272

AhmedBasem20 opened this issue Sep 14, 2023 · 1 comment · Fixed by #296

Comments

@AhmedBasem20
Copy link
Collaborator

V2 will allow deploying PR previews from forks.
@AhmedBasem20 AhmedBasem20 mentioned this issue Sep 14, 2023
Merged
@ltalirz ltalirz mentioned this issue Sep 30, 2023
Merged
@unkcpz
Copy link
Member

unkcpz commented Oct 2, 2023

From what is written here rossjrw/pr-preview-action#54
I think even in v2 it will raise the error message rather than allow it to workaround the permission limitation of GITHUB_TOKEN.

@unkcpz unkcpz mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow triggering pr-review from forked repo unkcpz/aiida-registry
2 participants
@unkcpz @AhmedBasem20