-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flexibility to PdosWorkChain
#697
base: main
Are you sure you want to change the base?
Conversation
Seems like my changes in #695 got dragged along, not sure how to remedy this... |
Also pinging @chrisjsewell, since it's his baby. I have just adapted it to the last version and added the |
Your git-literacy strikes again! 😅 Don't worry, I can have a look and fix it. We should really think about giving you a crash course some day |
The `nscf`, `dos` and `projwfc` steps are made optional which will allow a user to pass in the intermediate results that each step is supposed to create if they already obtained it through other means.
c9c9d2f
to
0b2052d
Compare
@zooks97 fixed the branch. Please have a look at the code to make sure nothing is missing. |
Heh, when I started using it properly, I also broke stuff all the time. When I asked @csadorf what in the world a rebase was, he told me (very sternly) that I should just sit down and fully read at least the first 3 chapters of the https://git-scm.com/book/en/v2 It really helped! I'm usually a try-and-break kind of guy, but for |
Will do, thanks! Sweet, I'll find some time to give this a read and hopefully I'll stop breaking things so much 😅 |
#696