Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibilities + matrix in README.md #1061

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Jan 18, 2025

Update the supported Python versions, and make the required changes in the compatibility matrix, also to reflect the effectively supported aiida-core version due to the update to pydantic~=2.4 in aiida-quantumespresso==2.5.0.

In 740e0be support was added for `pydantic~=2.4`. This
effectively changed the compatible `aiida-core` version to v2.5 or above, since from
this version `aiida-core` also depends directly on `pydantic~=2.4`.

However, we never adapted the compatibility matrix in the `README.md` to reflect this
restriction. This commit updates the compatibility matrix to reflect the correct
compatible versions of `aiida-core`.
@mbercx
Copy link
Member Author

mbercx commented Jan 18, 2025

Hmm, maybe adding Python 3.13 is a bit premature, since aiidateam/aiida-core#6600 is not yet merged. ^^

@mbercx mbercx force-pushed the fix/comp-matrix branch 3 times, most recently from 8e560c2 to 6d1e716 Compare January 18, 2025 16:38
@mbercx mbercx changed the title 📚 README.md: Correct aiida-core compatibility Update compatibilities + matrix in README.md Jan 18, 2025
@mbercx mbercx marked this pull request as ready for review January 18, 2025 16:51
@mbercx mbercx requested a review from sphuber January 18, 2025 16:51
@mbercx
Copy link
Member Author

mbercx commented Jan 18, 2025

@sphuber was updating the compatibility matrix for the v4.8.0 release, and saw that our supported aiida-core versions weren't really correct due to the change in pydantic version and also decided to update the Python versions while I was at it. Once this is merged I'll open a release PR.

@mbercx mbercx requested review from t-reents and Minotakm January 18, 2025 16:53
Since we now effectively only support `aiida-core` v2.5 and above - which has dropped
Python 3.8 support - we can also drop Python 3.8 support.

At the same time, we add support for Python version 3.12. The latest Python version 3.13
cannot be supported yet since there is not support for it in `aiida-core`.

Finally, the compatibility matrix in the `README.md` is updated to reflect these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants