Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag structure manager and viewer with CSS classes for easy styling #662

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

edan-bainglass
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (7353264) to head (056fc4f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   83.39%   83.41%   +0.01%     
==========================================
  Files          17       17              
  Lines        3578     3581       +3     
==========================================
+ Hits         2984     2987       +3     
  Misses        594      594              
Flag Coverage Δ
python-3.11 83.41% <100.00%> (+0.01%) ⬆️
python-3.9 83.44% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54
Copy link
Member

superstar54 commented Jan 11, 2025

The class is added but not used. So, is it necessary to add the class (hard-coded) here? The developer can add their class when using the widgets, right?

@edan-bainglass
Copy link
Member Author

edan-bainglass commented Jan 12, 2025

The class is added but not used. So, is it necessary to add the class (hard-coded) here? The developer can add their class when using the widgets, right?

Sure. But this way, they don't have to. We provide the widget with the class, so developers can just add styles in their stylesheets. Otherwise, let's say they use the structure manager in multiple places (as we do in aiidalab-qe), they'll have to tag each instance. Not ideal. Hence this PR.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. LGTM!

@edan-bainglass edan-bainglass merged commit 0ebfa1c into aiidalab:master Jan 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants