-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update uv in RTD config #660
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 17 17
Lines 3581 3581
=======================================
Hits 2987 2987
Misses 594 594
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- asdf global uv 0.5.17 | ||
create_environment: | ||
- uv venv $READTHEDOCS_VIRTUALENV_PATH | ||
install: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike with uv sync
which we use in aiida-core, here we can manually specify the target virtual environment with uv pip install
. This in turn let's us use the sphinx
section below instead of specifying the build command manually.
4732344
to
34d2fd6
Compare
I went ahead and merged this since the RTD build already started failing in other PR due to a missing sphinx.configuration key (see https://about.readthedocs.com/blog/2024/12/deprecate-config-files-without-sphinx-or-mkdocs-config/) |
See also discussion in aiidateam/aiida-core#6685.
Includes a fix from aiidateam/aiida-core#6700