Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uv in RTD config #660

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Jan 8, 2025

See also discussion in aiidateam/aiida-core#6685.
Includes a fix from aiidateam/aiida-core#6700

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (0ebfa1c) to head (80ebc2a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          17       17           
  Lines        3581     3581           
=======================================
  Hits         2987     2987           
  Misses        594      594           
Flag Coverage Δ
python-3.11 83.41% <ø> (ø)
python-3.9 83.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas marked this pull request as ready for review January 8, 2025 20:20
@danielhollas danielhollas requested a review from unkcpz January 11, 2025 09:40
- asdf global uv 0.5.17
create_environment:
- uv venv $READTHEDOCS_VIRTUALENV_PATH
install:
Copy link
Contributor Author

@danielhollas danielhollas Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike with uv sync which we use in aiida-core, here we can manually specify the target virtual environment with uv pip install. This in turn let's us use the sphinx section below instead of specifying the build command manually.

@danielhollas danielhollas merged commit 8444f81 into aiidalab:master Jan 13, 2025
11 checks passed
@danielhollas danielhollas deleted the rtd-uv-update branch January 13, 2025 14:54
@danielhollas
Copy link
Contributor Author

I went ahead and merged this since the RTD build already started failing in other PR due to a missing sphinx.configuration key (see https://about.readthedocs.com/blog/2024/12/deprecate-config-files-without-sphinx-or-mkdocs-config/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant