Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ipywidgets 8.x #644

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Support ipywidgets 8.x #644

wants to merge 11 commits into from

Conversation

yakutovicha
Copy link
Member

fixes #473

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.21%. Comparing base (dee5446) to head (2df17d6).

Files with missing lines Patch % Lines
aiidalab_widgets_base/computational_resources.py 22.22% 7 Missing ⚠️
aiidalab_widgets_base/structures.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
- Coverage   83.35%   83.21%   -0.14%     
==========================================
  Files          17       17              
  Lines        3586     3592       +6     
==========================================
  Hits         2989     2989              
- Misses        597      603       +6     
Flag Coverage Δ
python-3.11 83.21% <50.00%> (-0.14%) ⬇️
python-3.9 83.24% <50.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I had some comments during the hackathon that I forgot to submit.

@@ -28,8 +28,7 @@ install_requires =
humanfriendly~=10.0
ipytree~=0.2
traitlets~=5.4
ipywidgets~=7.7
widgetsnbextension<3.6.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to remove this. 🚀 Have you tested that the original reason for this widgetsnbextension pin no longer applies? (I think it was because of the NodeTree widget was broken?)

EDIT: It looks like we still need the widgetsnbextension based on our experience of omitting it in aiidalab-home. See this issue aiidalab/aiidalab-docker-stack#512 Definitely will need testing.

setup.cfg Outdated Show resolved Hide resolved
@yakutovicha yakutovicha force-pushed the update/support-ipw-8.x branch from cd75987 to 2df17d6 Compare February 4, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ipywidget 8.x
2 participants