-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ipywidgets 8.x #644
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 83.35% 83.21% -0.14%
==========================================
Files 17 17
Lines 3586 3592 +6
==========================================
Hits 2989 2989
- Misses 597 603 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, I had some comments during the hackathon that I forgot to submit.
@@ -28,8 +28,7 @@ install_requires = | |||
humanfriendly~=10.0 | |||
ipytree~=0.2 | |||
traitlets~=5.4 | |||
ipywidgets~=7.7 | |||
widgetsnbextension<3.6.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to remove this. 🚀 Have you tested that the original reason for this widgetsnbextension
pin no longer applies? (I think it was because of the NodeTree widget was broken?)
EDIT: It looks like we still need the widgetsnbextension based on our experience of omitting it in aiidalab-home. See this issue aiidalab/aiidalab-docker-stack#512 Definitely will need testing.
cd75987
to
2df17d6
Compare
fixes #473