Hubbard: change int values of eigenvalues to float #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
=======================================
Coverage 73.09% 73.09%
=======================================
Files 95 95
Lines 6578 6576 -2
=======================================
- Hits 4808 4807 -1
+ Misses 1770 1769 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…resOrtegaGuerrero/aiidalab-qe into starting_ns_eigenvalue_float
edan-bainglass
approved these changes
Feb 21, 2025
| @@ -143,7 +143,7 @@ def _define_default_eigenvalues(self): | |||
| [state + 1, spin, kind_name, -1] # default eigenvalue | |||
| for state in range(num_states) | |||
| ] | |||
| for spin in range(2) # spin up and down | |||
| for spin in [2, 1] # spin up and down | |||
There was a problem hiding this comment.
Why reversed? Is this a standard?
There was a problem hiding this comment.
i will reverse it ,
| state_index, | ||
| kind_name, | ||
| int(value), | ||
| float(value), |
There was a problem hiding this comment.
Ah, I see here that it is indeed expecting REAL. Good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values for the
starting_ns_eigenvalueshould be floats and not integersAt the moment the app was doing two errors
The test was testing spin down as 1.
This PR changes the values to floats and corrects the tests. Closes #1176