Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the final results tab with the structure, add a table with coordinates #1050

Open
edan-bainglass opened this issue Jan 3, 2025 · 3 comments
Assignees

Comments

@edan-bainglass
Copy link
Member

  • This should appear both in the "Relaxed structure" and in the "Initial structure" if there was no relaxation
  • The table should have the following columns:
    • Atom index (1-based as this is done everywhere)
    • Chemical symbol
    • Tag [for the previous and this one, discuss with @AndresOrtegaGuerrero to be consistent with how this is done and shown in the input]
    • 3 columns with x, y, z coordinates (angstrom), with 2 digits after the comma
  • (Ideally) If a table row is clicked, the corresponding atom is visualized

Moreover, in the same tab, add some information about the periodicity (e.g. at the very top before the visualizer, or somewhere else appropriate). E.g. "Structure periodicity: xyz", using the same string (xyz or other) that was used in the rest of the app (check with @AndresOrtegaGuerrero as this is being changed)

@AndresOrtegaGuerrero
Copy link
Member

Moreover, in the same tab, add some information about the periodicity (e.g. at the very top before the visualizer, or somewhere else appropriate). E.g. "Structure periodicity: xyz", using the same string (xyz or other) that was used in the rest of the app (check with @AndresOrtegaGuerrero as this is being changed)

If the structure widget already displays periodicity information in the cell tab:
image

Instead of adding a separate widget to represent cell information, we can simply initialize the structure widget to display the cell by default.

@AndresOrtegaGuerrero
Copy link
Member

AndresOrtegaGuerrero commented Jan 5, 2025

(Ideally) If a table row is clicked, the corresponding atom is visualized

(I think) To achieve this, the AiiDAlab-widget base Structure visualizer widget should be replaced with the WEAS widget. The implementation could then follow the approach used by @superstar54 (Or can this be done without WEAS ? ) in the HP plugin.

@edan-bainglass
Copy link
Member Author

FYI, @giovannipizzi opened this proposal on the project page. I just transferred it hear, hence my account 😅 Best Giovanni comment on the above suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants