Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficient automated GitHub testing #153

Merged
merged 25 commits into from
Dec 9, 2024
Merged

Efficient automated GitHub testing #153

merged 25 commits into from
Dec 9, 2024

Conversation

kathrynle20
Copy link
Contributor

@kathrynle20 kathrynle20 commented Dec 4, 2024 •
edited
Loading

Optimized automated GitHub testing to run faster with these changes:

  • Created additional value for configs called "workflow_test". Set this value to True if you want to run in testing mode
  • Testing mode will reduce the test set size. Currently the test set size is reduced from 10,000 to 1,000.
  • Made changes to main_grpc.py to include an extra argument to indicate that we want to spin nodes that run in testing mode. Set the argument -dev to True if testing and False if not.

Result: Test Training Code with gRPC GitHub Action runs in 4 mins compared to 13 mins previously.

@kathrynle20 kathrynle20 marked this pull request as ready for review December 4, 2024 22:12
@kathrynle20 kathrynle20 changed the title Optimizing automated GitHub testing Efficient automated GitHub testing Dec 4, 2024
@kathrynle20
Copy link
Contributor Author

Testing now runs on the fedstatic algorithm. The fedstatic server now downloads the dataset.

tremblerz
tremblerz requested changes Dec 7, 2024
View reviewed changes
src/configs/sys_config.py Outdated
@@ -158,10 +158,10 @@ def get_digit_five_support(num_users: int, domains: List[str] = DIGIT_FIVE):
CIAR10_DPATH = "./datasets/imgs/cifar10/"

NUM_COLLABORATORS = 1
# DUMP_DIR = "../../../../../../../home/"
DUMP_DIR = "/tmp/"
DUMP_DIR = "/Users/kathryn/MIT/UROP/Media Lab/sonar_experiments/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this.

@tremblerz tremblerz merged commit 7962bce into aidecentralized:main Dec 9, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremblerz tremblerz tremblerz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kathrynle20 @tremblerz