Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ThumbnailError when input file is None #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for ThumbnailError when input file is None #1

wants to merge 4 commits into from

Conversation

alurin
Copy link

@alurin alurin commented Feb 26, 2014

When first argument of get_thumbnail is None, original ThumbnailBackend backend return dummy or None.

This commit is fixed this.

@aidanlister
Copy link
Owner

Hey alurin, thanks for using the module! I can't test this at the moment, but it seems like this would return a dummy image rather than returning the full unscaled image which might not be as desirable?

@alurin
Copy link
Author

alurin commented Mar 17, 2014

It's only depends on sorl thumbnails settings for dummy thumbs. I think it's a good idea to return dummy image, if it's require by user settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants