Steps #7
Merged
Steps #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamshen-nz
commented
Apr 20, 2022
|
|
||
|
|
There was a problem hiding this comment.
Can blame pycharm for re-indenting everything... Only added print stuff here
| if verbose: | ||
| if result == "" and self.process.poll() is not None: | ||
| # Process has finished | ||
| assert self.finished, "Process finished but not marked as finished" |
There was a problem hiding this comment.
Maybe we should remove this check and let whatever is calling it handle it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding steps before simulation, steps per simulation
Improve evaluate script
And other stuff I forgot about