Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content 2 #8

Merged
merged 9 commits into from
Oct 11, 2019
Merged

Add content 2 #8

merged 9 commits into from
Oct 11, 2019

Conversation

Aichnerc
Copy link
Member

@Aichnerc Aichnerc commented Oct 11, 2019 •
edited
Loading

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • There is no actual content in those sections yet.

@Aichnerc
Remove margin
ba52be6 
The margin-top of the footer has been removed to
fix a white space that appeared above the footer.
@Aichnerc
Add About component
6a37f50 
The About component has been added. It will include
details about the artist.
@Aichnerc
Remove temporal margin
29b1135 
The temporal margin to simulate a body has been
removed.
@Aichnerc
Remove navigation functions from Intro
68a017b 
The intro has been designed by MDB to include
a navigation bar. The navigation bar has been moved
to a molecule instead. The remaining functions and
variables associated with navigation have been removed.
@Aichnerc
Improve footer text
e656482 
The text for the support area of the footer has been
improved.
@Aichnerc
Add Merch and Gallery components
b8cc6a0 
The merch and gallery components have been
added. The fetching of the merch shop does not
work yet.
@Aichnerc
Update MDB
e5c0048 
MDB has been updated to 4.21.0
@Aichnerc
Add Gallery component to Homepage
9321bdd 
The Gallery component is now being rendered
on the homepage.
@Aichnerc
Add testimage
c0be969 
A testimage has been added to test the gallery.
@Aichnerc Aichnerc added the enhancement New feature or request label Oct 11, 2019
@Aichnerc Aichnerc requested a review from sweggerat October 11, 2019 10:01
@Aichnerc Aichnerc self-assigned this Oct 11, 2019
Aichnerc
Aichnerc commented Oct 11, 2019
View reviewed changes
Copy link
Member Author

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me!

sweggerat
sweggerat approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@sweggerat sweggerat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

@sweggerat sweggerat merged commit 992af55 into master Oct 11, 2019
This was referenced Oct 11, 2019
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweggerat sweggerat sweggerat approved these changes

Assignees

@Aichnerc Aichnerc

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aichnerc @sweggerat