Migrate to kyaml #412
Open
Migrate to kyaml #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is excellent contribution, thanks. I learned this was possible after I implemented the initial Go version but never went back to incorporate, so thanks for doing the hard work there. I'll make sure to review soon. |
|
Issue from CI: kubernetes/client-go#1269 Seems like client-go should be updated. |
|
Also maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #327.
Some notes:
--- FAIL: TestKubeconfig_NamespaceOfContext_ctxNotFound (0.00s) namespace_test.go:34: expected errBecause without context we're expecting err, it hard to use
Pipe(yaml.Lookup("contexts", "[name={ctxName}]", "context", "namespace")). If context doesn't exists,nilwill be returned, just like if context doesn't have namespace, or kubeconfig doesn't have contexts.yaml.GetValue(node)is used instead ofnode.String()because last method doesn't work well with primitives like strings (e.g. "" instead of empty string).