Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when no contexts are found in kubeconfig #259

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ChaturvediSulabh
Copy link

@ChaturvediSulabh ChaturvediSulabh commented Aug 18, 2020

See the proposal here

What did I do?

  1. Added message for empty contexts in both fzf.go and lists.go
  2. Updated Implementation test 17
  3. Tested Locally

Screenshot 2020-08-18 at 18 33 28

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

cmd/kubectx/list.go Outdated Show resolved Hide resolved
@ahmetb
Copy link
Owner

ahmetb commented Aug 18, 2020

You need to implement integration tests as well I believe.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ChaturvediSulabh
Copy link
Author

@googlebot I fixed it

@googlebot I fixed it

@ChaturvediSulabh
Copy link
Author

You need to implement integration tests as well I believe.

test case 17, delete several contexts validates this, I've updated the test case. Should I still write a separate test for this?

@ahmetb
Copy link
Owner

ahmetb commented Aug 18, 2020

you're right it's technically capturing this case, but it's more ideal if we copy-paste it into its own test case. technically we want to have 1:1 mapping between "behavior we want to test" and "integration test case".

cmd/kubectx/fzf.go Outdated Show resolved Hide resolved
@ChaturvediSulabh ChaturvediSulabh changed the title In respond to Proposal#241- Add message when no contexts are found in kubeconfig Add message when no contexts are found in kubeconfig Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants