This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
BC: added pagination for location feed #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopaygorodsky
approved these changes
Aug 22, 2019
ahmdrz
suggested changes
Aug 23, 2019
| //Feeds creates a starting point for fetching location feed. | ||
| //Use .Next() for pagination. | ||
| //Tab can be "recent" or "top" according to instagram sections | ||
| func (l *LocationInstance) Feeds(locationID int64, tab string) *Section { |
There was a problem hiding this comment.
Can you create two new constants for tab option? Something like TabRecent.
| if section.err != nil { | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
We can paginate only if MoreAvailable is true. So please write an if condition instead of checking errors. It's more readable for humans :D
|
Also please make some test functions for Location if you can. |
Hello, how did you do with this? @merzl |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add ability to paginate over location feed, in the same was as Followers using .Next() function.
One BC: added option to select a tab for posts (recent or top).