Revert "Prefer calloc over of malloc+zeroMemory. NFC" (emscripten-c…

…ore#22568) Reverts emscripten-core#22460 It's causing ASan/LSan failures: https://ci.chromium.org/ui/p/emscripten-releases/builders/ci/linux-test-suites/b8737231127543572609/overview I'm going to revert rather than fixing forward because I'm preparing a release.
aheejin · Sep 13, 2024 · 50e0b07 · 50e0b07
1 parent d0d9966
commit 50e0b07
Show file tree

Hide file tree

Showing 11 changed files with 18 additions and 16 deletions.
diff --git a/src/library_dylink.js b/src/library_dylink.js
@@ -363,7 +363,7 @@ var LibraryDylink = {
   // Allocate memory even if malloc isn't ready yet.  The allocated memory here
   // must be zero initialized since its used for all static data, including bss.
   $getMemory__noleakcheck: true,
-  $getMemory__deps: ['$GOT', '__heap_base', '$alignMemory', 'calloc'],
+  $getMemory__deps: ['$GOT', '__heap_base', '$zeroMemory', '$alignMemory', 'malloc'],
   $getMemory: (size) => {
     // After the runtime is initialized, we must only use sbrk() normally.
 #if DYLINK_DEBUG
@@ -373,7 +373,7 @@ var LibraryDylink = {
       // Currently we don't support freeing of static data when modules are
       // unloaded via dlclose.  This function is tagged as `noleakcheck` to
       // avoid having this reported as leak.
-      return _calloc(size, 1);
+      return zeroMemory(_malloc(size), size);
     }
     var ret = ___heap_base;
     // Keep __heap_base stack aligned.
@@ -599,7 +599,7 @@ var LibraryDylink = {
   $loadWebAssemblyModule__deps: [
     '$loadDynamicLibrary', '$getMemory',
     '$relocateExports', '$resolveGlobalSymbol', '$GOTHandler',
-    '$getDylinkMetadata', '$alignMemory',
+    '$getDylinkMetadata', '$alignMemory', '$zeroMemory',
     '$currentModuleWeakSymbols',
     '$updateTableMap',
     '$wasmTable',

diff --git a/src/library_pthread.js b/src/library_pthread.js
@@ -35,7 +35,7 @@ var LibraryPThread = {
   $PThread__postset: 'PThread.init();',
   $PThread__deps: ['_emscripten_thread_init',
                    '$terminateWorker',
-                   '$cleanupThread',
+                   '$cleanupThread', '$zeroMemory',
 #if MAIN_MODULE
                    '$markAsFinished',
 #endif

diff --git a/src/library_sdl.js b/src/library_sdl.js
@@ -1357,7 +1357,7 @@ var LibrarySDL = {
     return SDL.version;
   },
 
-  SDL_Init__deps: ['calloc', 'memcpy'],
+  SDL_Init__deps: ['$zeroMemory', 'memcpy'],
   SDL_Init__proxy: 'sync',
   SDL_Init__docs: '/** @param{number} initFlags */',
   SDL_Init: (initFlags) => {
@@ -1376,7 +1376,8 @@ var LibrarySDL = {
     }
 
     window.addEventListener("unload", SDL.receiveEvent);
-    SDL.keyboardState = _calloc(0x10000, 1); // Our SDL needs 512, but 64K is safe for older SDLs
+    SDL.keyboardState = _malloc(0x10000); // Our SDL needs 512, but 64K is safe for older SDLs
+    zeroMemory(SDL.keyboardState, 0x10000);
     // Initialize this structure carefully for closure
     SDL.DOMEventToSDLEvent['keydown']    = 0x300  /* SDL_KEYDOWN */;
     SDL.DOMEventToSDLEvent['keyup']      = 0x301  /* SDL_KEYUP */;
@@ -1412,10 +1413,11 @@ var LibrarySDL = {
     return 1;
   },
 
-  SDL_GetVideoInfo__deps: ['calloc'],
+  SDL_GetVideoInfo__deps: ['$zeroMemory'],
   SDL_GetVideoInfo__proxy: 'sync',
   SDL_GetVideoInfo: () => {
-    var ret = _calloc({{{ C_STRUCTS.SDL_VideoInfo.__size__ }}}, 1);
+    var ret = _malloc({{{ C_STRUCTS.SDL_VideoInfo.__size__ }}});
+    zeroMemory(ret, {{{ C_STRUCTS.SDL_version.__size__ }}});
     {{{ makeSetValue('ret', C_STRUCTS.SDL_VideoInfo.current_w, 'Module["canvas"].width', 'i32') }}};
     {{{ makeSetValue('ret', C_STRUCTS.SDL_VideoInfo.current_h, 'Module["canvas"].height', 'i32') }}};
     return ret;

diff --git a/test/other/codesize/test_codesize_hello_dylink.exports b/test/other/codesize/test_codesize_hello_dylink.exports
@@ -2,8 +2,8 @@ __wasm_apply_data_relocs
 __wasm_call_ctors
 _emscripten_stack_alloc
 _emscripten_stack_restore
-calloc
 dynCall_jiji
 emscripten_stack_get_current
 main
+malloc
 setThrew
diff --git a/test/other/codesize/test_codesize_hello_dylink.funcs b/test/other/codesize/test_codesize_hello_dylink.funcs
@@ -8,7 +8,7 @@ $__wasm_apply_global_relocs
 $__wasm_call_ctors
 $_emscripten_stack_alloc
 $_emscripten_stack_restore
-$dlcalloc
+$dlmalloc
 $emscripten_stack_get_current
 $legalstub$dynCall_jiji
 $main

diff --git a/test/other/codesize/test_codesize_hello_dylink.gzsize b/test/other/codesize/test_codesize_hello_dylink.gzsize
@@ -1 +1 @@
-6285
+6292
diff --git a/test/other/codesize/test_codesize_hello_dylink.jssize b/test/other/codesize/test_codesize_hello_dylink.jssize
@@ -1 +1 @@
-13820
+13833
diff --git a/test/other/codesize/test_codesize_hello_dylink.size b/test/other/codesize/test_codesize_hello_dylink.size
@@ -1 +1 @@
-9763
+9350
diff --git a/test/test_core.py b/test/test_core.py
@@ -1943,7 +1943,9 @@ def test_em_asm_side_module(self):
   def test_em_js(self, args, force_c):
     if '-sMAIN_MODULE=2' in args:
       self.check_dylink()
-    self.emcc_args += ['-sEXPORTED_FUNCTIONS=_main,_malloc'] + args
+    else:
+      self.emcc_args += ['-sEXPORTED_FUNCTIONS=_main,_malloc']
+    self.emcc_args += args
     if '-pthread' in args:
       self.setup_node_pthreads()
 

diff --git a/test/test_other.py b/test/test_other.py
@@ -2189,7 +2189,6 @@ def test_dylink_pthread_bigint_em_asm(self):
   def test_dylink_pthread_bigint_em_js(self):
     self.set_setting('MAIN_MODULE', 2)
     self.set_setting('WASM_BIGINT')
-    self.set_setting('EXPORTED_FUNCTIONS', '_malloc,_main')
     self.emcc_args += ['-Wno-experimental', '-pthread']
     self.do_runf('core/test_em_js.cpp')
 

diff --git a/tools/emscripten.py b/tools/emscripten.py
@@ -1023,7 +1023,6 @@ def create_pointer_conversion_wrappers(metadata):
     '_emscripten_stack_alloc': 'pp',
     'emscripten_builtin_malloc': 'pp',
     'malloc': 'pp',
-    'calloc': 'ppp',
     'webidl_malloc': 'pp',
     'memalign': 'ppp',
     'memcmp': '_ppp',