cxx-qt-gen: impl Deref for qobject::T to reach T easily

Related to KDAB#559
ahayzen-kdab · Jun 21, 2023 · b8c2ed9 · b8c2ed9
1 parent 6611f4f
commit b8c2ed9
Show file tree

Hide file tree

Showing 16 changed files with 99 additions and 30 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Ensure that generated Rust code works when `#![deny(missing_docs)]` is enabled
 - Ability to connect and disconnect from signals in Rust triggering a function pointer
 - `unsafe impl !cxx_qt::Locking for qobject::T` to disable internal locking
+- `Deref` is now implemented for `qobject::T` to reach the `T` Rust struct
 
 ### Changed
 

diff --git a/crates/cxx-qt-gen/src/generator/rust/property/getter.rs b/crates/cxx-qt-gen/src/generator/rust/property/getter.rs
@@ -43,7 +43,7 @@ pub fn generate(
                     #[doc = "Getter for the Q_PROPERTY "]
                     #[doc = #ident_str]
                     pub fn #getter_rust(&self) -> &#ty {
-                        &self.rust().#ident
+                        &self.#ident
                     }
                 }
             },

diff --git a/crates/cxx-qt-gen/src/generator/rust/property/mod.rs b/crates/cxx-qt-gen/src/generator/rust/property/mod.rs
@@ -120,7 +120,7 @@ mod tests {
                     #[doc = "Getter for the Q_PROPERTY "]
                     #[doc = "trivial_property"]
                     pub fn trivial_property(&self) -> &i32 {
-                        &self.rust().trivial_property
+                        &self.trivial_property
                     }
                 }
             },
@@ -154,7 +154,7 @@ mod tests {
                     #[doc = "Setter for the Q_PROPERTY "]
                     #[doc = "trivial_property"]
                     pub fn set_trivial_property(mut self: Pin<&mut Self>, value: i32) {
-                        if self.rust().trivial_property == value {
+                        if self.trivial_property == value {
                             return;
                         }
                         self.as_mut().rust_mut().trivial_property = value;
@@ -194,7 +194,7 @@ mod tests {
                     #[doc = "Getter for the Q_PROPERTY "]
                     #[doc = "opaque_property"]
                     pub fn opaque_property(&self) -> &UniquePtr<QColor> {
-                        &self.rust().opaque_property
+                        &self.opaque_property
                     }
                 }
             },
@@ -228,7 +228,7 @@ mod tests {
                     #[doc = "Setter for the Q_PROPERTY "]
                     #[doc = "opaque_property"]
                     pub fn set_opaque_property(mut self: Pin<&mut Self>, value: UniquePtr<QColor>) {
-                        if self.rust().opaque_property == value {
+                        if self.opaque_property == value {
                             return;
                         }
                         self.as_mut().rust_mut().opaque_property = value;
@@ -268,7 +268,7 @@ mod tests {
                     #[doc = "Getter for the Q_PROPERTY "]
                     #[doc = "unsafe_property"]
                     pub fn unsafe_property(&self) -> &*mut T {
-                        &self.rust().unsafe_property
+                        &self.unsafe_property
                     }
                 }
             },
@@ -302,7 +302,7 @@ mod tests {
                     #[doc = "Setter for the Q_PROPERTY "]
                     #[doc = "unsafe_property"]
                     pub fn set_unsafe_property(mut self: Pin<&mut Self>, value: *mut T) {
-                        if self.rust().unsafe_property == value {
+                        if self.unsafe_property == value {
                             return;
                         }
                         self.as_mut().rust_mut().unsafe_property = value;

diff --git a/crates/cxx-qt-gen/src/generator/rust/property/setter.rs b/crates/cxx-qt-gen/src/generator/rust/property/setter.rs
@@ -51,7 +51,7 @@ pub fn generate(
                     #[doc = "Setter for the Q_PROPERTY "]
                     #[doc = #ident_str]
                     pub fn #setter_rust(mut self: Pin<&mut Self>, value: #ty) {
-                        if self.rust().#ident == value {
+                        if self.#ident == value {
                             // don't want to set the value again and reemit the signal,
                             // as this can cause binding loops
                             return;

diff --git a/crates/cxx-qt-gen/src/writer/rust/mod.rs b/crates/cxx-qt-gen/src/writer/rust/mod.rs
@@ -58,6 +58,15 @@ fn cxx_qt_common_blocks(qobject: &GeneratedRustQObject) -> Vec<TokenStream> {
     let create_rs_ident = mangle("create_rs", rust_struct_ident);
 
     vec![
+        quote! {
+            impl core::ops::Deref for #cpp_struct_ident {
+                type Target = #rust_struct_ident;
+
+                fn deref(&self) -> &Self::Target {
+                    self.cxx_qt_ffi_rust()
+                }
+            }
+        },
         quote! {
             impl cxx_qt::CxxQtType for #cpp_struct_ident {
                 type Rust = #rust_struct_ident;
@@ -421,6 +430,14 @@ mod tests {
                     }
                 }
 
+                impl core::ops::Deref for MyObjectQt {
+                    type Target = MyObject;
+
+                    fn deref(&self) -> &Self::Target {
+                        self.cxx_qt_ffi_rust()
+                    }
+                }
+
                 impl cxx_qt::CxxQtType for MyObjectQt {
                     type Rust = MyObject;
                     fn rust(&self) -> &Self::Rust {
@@ -554,6 +571,14 @@ mod tests {
                     }
                 }
 
+                impl core::ops::Deref for FirstObjectQt {
+                    type Target = FirstObject;
+
+                    fn deref(&self) -> &Self::Target {
+                        self.cxx_qt_ffi_rust()
+                    }
+                }
+
                 impl cxx_qt::CxxQtType for FirstObjectQt {
                     type Rust = FirstObject;
                     fn rust(&self) -> &Self::Rust {
@@ -578,6 +603,14 @@ mod tests {
                     }
                 }
 
+                impl core::ops::Deref for SecondObjectQt {
+                    type Target = SecondObject;
+
+                    fn deref(&self) -> &Self::Target {
+                        self.cxx_qt_ffi_rust()
+                    }
+                }
+
                 impl cxx_qt::CxxQtType for SecondObjectQt {
                     type Rust = SecondObject;
                     fn rust(&self) -> &Self::Rust {

diff --git a/crates/cxx-qt-gen/test_outputs/inheritance.rs b/crates/cxx-qt-gen/test_outputs/inheritance.rs
@@ -85,6 +85,12 @@ pub mod cxx_qt_inheritance {
         data: Vec<i32>,
     }
     impl cxx_qt::Locking for MyObjectQt {}
+    impl core::ops::Deref for MyObjectQt {
+        type Target = MyObject;
+        fn deref(&self) -> &Self::Target {
+            self.cxx_qt_ffi_rust()
+        }
+    }
     impl cxx_qt::CxxQtType for MyObjectQt {
         type Rust = MyObject;
         fn rust(&self) -> &Self::Rust {

diff --git a/crates/cxx-qt-gen/test_outputs/invokables.rs b/crates/cxx-qt-gen/test_outputs/invokables.rs
@@ -284,6 +284,12 @@ pub mod cxx_qt_ffi {
         inner: std::boxed::Box<dyn FnOnce(std::pin::Pin<&mut MyObjectQt>) + Send>,
     }
     impl cxx_qt::Locking for MyObjectQt {}
+    impl core::ops::Deref for MyObjectQt {
+        type Target = MyObject;
+        fn deref(&self) -> &Self::Target {
+            self.cxx_qt_ffi_rust()
+        }
+    }
     impl cxx_qt::CxxQtType for MyObjectQt {
         type Rust = MyObject;
         fn rust(&self) -> &Self::Rust {

diff --git a/crates/cxx-qt-gen/test_outputs/passthrough_and_naming.rs b/crates/cxx-qt-gen/test_outputs/passthrough_and_naming.rs
@@ -259,7 +259,7 @@ pub mod cxx_qt_ffi {
         #[doc = "Getter for the Q_PROPERTY "]
         #[doc = "property_name"]
         pub fn property_name(&self) -> &i32 {
-            &self.rust().property_name
+            &self.property_name
         }
     }
     impl MyObject {
@@ -272,7 +272,7 @@ pub mod cxx_qt_ffi {
         #[doc = "Setter for the Q_PROPERTY "]
         #[doc = "property_name"]
         pub fn set_property_name(mut self: Pin<&mut Self>, value: i32) {
-            if self.rust().property_name == value {
+            if self.property_name == value {
                 return;
             }
             self.as_mut().rust_mut().property_name = value;
@@ -308,6 +308,12 @@ pub mod cxx_qt_ffi {
         }
     }
     impl cxx_qt::Locking for MyObjectQt {}
+    impl core::ops::Deref for MyObjectQt {
+        type Target = MyObject;
+        fn deref(&self) -> &Self::Target {
+            self.cxx_qt_ffi_rust()
+        }
+    }
     impl cxx_qt::CxxQtType for MyObjectQt {
         type Rust = MyObject;
         fn rust(&self) -> &Self::Rust {
@@ -339,7 +345,7 @@ pub mod cxx_qt_ffi {
         #[doc = "Getter for the Q_PROPERTY "]
         #[doc = "property_name"]
         pub fn property_name(&self) -> &i32 {
-            &self.rust().property_name
+            &self.property_name
         }
     }
     impl SecondObject {
@@ -352,7 +358,7 @@ pub mod cxx_qt_ffi {
         #[doc = "Setter for the Q_PROPERTY "]
         #[doc = "property_name"]
         pub fn set_property_name(mut self: Pin<&mut Self>, value: i32) {
-            if self.rust().property_name == value {
+            if self.property_name == value {
                 return;
             }
             self.as_mut().rust_mut().property_name = value;
@@ -387,6 +393,12 @@ pub mod cxx_qt_ffi {
             self.connect_ready(func, CxxQtConnectionType::AutoConnection)
         }
     }
+    impl core::ops::Deref for SecondObjectQt {
+        type Target = SecondObject;
+        fn deref(&self) -> &Self::Target {
+            self.cxx_qt_ffi_rust()
+        }
+    }
     impl cxx_qt::CxxQtType for SecondObjectQt {
         type Rust = SecondObject;
         fn rust(&self) -> &Self::Rust {

diff --git a/crates/cxx-qt-gen/test_outputs/properties.rs b/crates/cxx-qt-gen/test_outputs/properties.rs
@@ -127,7 +127,7 @@ pub mod cxx_qt_ffi {
         #[doc = "Getter for the Q_PROPERTY "]
         #[doc = "primitive"]
         pub fn primitive(&self) -> &i32 {
-            &self.rust().primitive
+            &self.primitive
         }
     }
     impl MyObject {
@@ -140,7 +140,7 @@ pub mod cxx_qt_ffi {
         #[doc = "Setter for the Q_PROPERTY "]
         #[doc = "primitive"]
         pub fn set_primitive(mut self: Pin<&mut Self>, value: i32) {
-            if self.rust().primitive == value {
+            if self.primitive == value {
                 return;
             }
             self.as_mut().rust_mut().primitive = value;
@@ -157,7 +157,7 @@ pub mod cxx_qt_ffi {
         #[doc = "Getter for the Q_PROPERTY "]
         #[doc = "trivial"]
         pub fn trivial(&self) -> &QPoint {
-            &self.rust().trivial
+            &self.trivial
         }
     }
     impl MyObject {
@@ -170,7 +170,7 @@ pub mod cxx_qt_ffi {
         #[doc = "Setter for the Q_PROPERTY "]
         #[doc = "trivial"]
         pub fn set_trivial(mut self: Pin<&mut Self>, value: QPoint) {
-            if self.rust().trivial == value {
+            if self.trivial == value {
                 return;
             }
             self.as_mut().rust_mut().trivial = value;
@@ -206,6 +206,12 @@ pub mod cxx_qt_ffi {
         }
     }
     impl cxx_qt::Locking for MyObjectQt {}
+    impl core::ops::Deref for MyObjectQt {
+        type Target = MyObject;
+        fn deref(&self) -> &Self::Target {
+            self.cxx_qt_ffi_rust()
+        }
+    }
     impl cxx_qt::CxxQtType for MyObjectQt {
         type Rust = MyObject;
         fn rust(&self) -> &Self::Rust {

diff --git a/crates/cxx-qt-gen/test_outputs/signals.rs b/crates/cxx-qt-gen/test_outputs/signals.rs
@@ -201,6 +201,12 @@ pub mod cxx_qt_ffi {
         }
     }
     impl cxx_qt::Locking for MyObjectQt {}
+    impl core::ops::Deref for MyObjectQt {
+        type Target = MyObject;
+        fn deref(&self) -> &Self::Target {
+            self.cxx_qt_ffi_rust()
+        }
+    }
     impl cxx_qt::CxxQtType for MyObjectQt {
         type Rust = MyObject;
         fn rust(&self) -> &Self::Rust {

diff --git a/examples/demo_threading/rust/src/lib.rs b/examples/demo_threading/rust/src/lib.rs
@@ -116,7 +116,7 @@ impl ffi::EnergyUsageQt {
 
     /// A Q_INVOKABLE which starts the TCP server
     fn start_server(mut self: Pin<&mut Self>) {
-        if self.rust().join_handles.is_some() {
+        if self.join_handles.is_some() {
             println!("Already running a server!");
             return;
         }

diff --git a/examples/qml_features/rust/src/custom_base_class.rs b/examples/qml_features/rust/src/custom_base_class.rs
@@ -207,11 +207,11 @@ impl ffi::CustomBaseClassQt {
     }
 
     fn add_cpp_context(mut self: Pin<&mut Self>) {
-        let count = self.as_ref().rust().vector.len();
+        let count = self.vector.len();
         unsafe {
             self.as_mut()
                 .begin_insert_rows(&QModelIndex::default(), count as i32, count as i32);
-            let id = self.as_ref().rust().id;
+            let id = self.id;
             self.as_mut().rust_mut().id = id + 1;
             self.as_mut()
                 .rust_mut()
@@ -253,7 +253,7 @@ impl ffi::CustomBaseClassQt {
 
     /// Remove the row with the given index
     pub fn remove(mut self: Pin<&mut Self>, index: i32) {
-        if index < 0 || (index as usize) >= self.as_ref().rust().vector.len() {
+        if index < 0 || (index as usize) >= self.vector.len() {
             return;
         }
 
@@ -279,7 +279,7 @@ impl ffi::CustomBaseClassQt {
     pub const VALUE_ROLE: i32 = 1;
 
     fn data(&self, index: &QModelIndex, role: i32) -> QVariant {
-        if let Some((id, value)) = self.rust().vector.get(index.row() as usize) {
+        if let Some((id, value)) = self.vector.get(index.row() as usize) {
             return match role {
                 Self::ID_ROLE => QVariant::from(id),
                 Self::VALUE_ROLE => QVariant::from(value),
@@ -313,7 +313,7 @@ impl ffi::CustomBaseClassQt {
 
     /// Return the row count for the QAbstractListModel
     pub fn row_count(&self, _parent: &QModelIndex) -> i32 {
-        self.rust().vector.len() as i32
+        self.vector.len() as i32
     }
 }
 // ANCHOR_END: book_macro_code
diff --git a/examples/qml_features/rust/src/invokables.rs b/examples/qml_features/rust/src/invokables.rs
@@ -61,7 +61,7 @@ use cxx_qt_lib::QColor;
 impl ffi::RustInvokablesQt {
     /// Immutable invokable method that returns the QColor
     fn load_color(&self) -> QColor {
-        self.rust().as_qcolor()
+        self.as_qcolor()
     }
 
     /// Mutable invokable method that stores a color

diff --git a/examples/qml_features/rust/src/signals.rs b/examples/qml_features/rust/src/signals.rs
@@ -93,7 +93,7 @@ impl ffi::RustSignalsQt {
             // Determine if logging is enabled
             if *qobject.as_ref().logging_enabled() {
                 // If no connections have been made, then create them
-                if qobject.as_ref().rust().connections.is_none() {
+                if qobject.as_ref().connections.is_none() {
                     // ANCHOR: book_signals_connect
                     let connections = [
                         qobject.as_mut().on_connected(|_, url| {

diff --git a/tests/basic_cxx_qt/rust/src/lib.rs b/tests/basic_cxx_qt/rust/src/lib.rs
@@ -120,6 +120,6 @@ impl ffi::MyObjectQt {
     }
 
     fn fetch_update_call_count(&self) -> i32 {
-        self.rust().update_call_count
+        self.update_call_count
     }
 }