Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed/corrected type annotations #219

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Changed/corrected type annotations #219

merged 1 commit into from
Feb 19, 2024

Conversation

agronholm
Copy link
Owner

Fixes #216.

@coveralls
Copy link

Coverage Status

coverage: 93.37%. remained the same
when pulling 94bb92a on fix-type-annotations
into 67b6472 on master.

abrisco
abrisco approved these changes Feb 19, 2024
View reviewed changes
Copy link

@abrisco abrisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me! It even looks more correct than what I initially reported. Thank you for updating this <3

@agronholm agronholm merged commit 2eeaab8 into master Feb 19, 2024
13 checks passed
@agronholm agronholm deleted the fix-type-annotations branch February 19, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrisco abrisco abrisco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect mypy types
3 participants
@agronholm @coveralls @abrisco