-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aform] add adropdown features #236
Conversation
lauty95
commented
Jan 10, 2025
- Handle external clicks: Modified the handleClickOutside function to ensure results only close when clicking outside the component.
- Fixed result selection: Updated the setResult function to pass the selected result correctly to closeResults.
- Improved result closing: Adjusted the closeResults function to handle optional parameters and only clear the search when necessary.
Coverage Report for ./aform
File Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lauty95 I think the dropdown should return all possible results when clicked, but I'm only seeing the selected value (the test failure might be related too).
I changed the onFocus event to display all possible results when clicked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I still see the tests failing due to this error: "ERROR: Coverage for branches (66.66%) does not meet the global threshold (70%)".
@lauty95 This is fine to ignore. As we add more tests, that number should go beyond the threshold.