Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aform] add adropdown features #236

Merged
merged 10 commits into from
Jan 20, 2025
Merged

[aform] add adropdown features #236

merged 10 commits into from
Jan 20, 2025

Conversation

lauty95
Copy link
Collaborator

@lauty95 lauty95 commented Jan 10, 2025

  • Handle external clicks: Modified the handleClickOutside function to ensure results only close when clicking outside the component.
  • Fixed result selection: Updated the setResult function to pass the selected result correctly to closeResults.
  • Improved result closing: Adjusted the closeResults function to handle optional parameters and only clear the search when necessary.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Coverage Report for ./aform

Status Category Percentage Covered / Total
🟢 Lines 85.06% (🎯 70%) 205 / 241
🟢 Statements 84% (🎯 70%) 210 / 250
🟢 Functions 75% (🎯 70%) 39 / 52
🔴 Branches 61.26% (🎯 70%) 87 / 142
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
aform/src/components/form/ADropdown.vue 84.21% 47.72% 72.72% 86.79% 51, 61, 76-79, 86, 94, 114
Unchanged Files
aform/src/components/AForm.vue 90% 40% 85.71% 90% 40-41
aform/src/components/base/CollapseButton.vue 100% 100% 100% 100%
aform/src/components/form/ACheckbox.vue 100% 100% 100% 100%
aform/src/components/form/AComboBox.vue 0% 0% 100% 0% 2-1
aform/src/components/form/ADate.vue 66.66% 66.66% 33.33% 66.66% 32, 42, 4
aform/src/components/form/ADatePicker.vue 95% 81.81% 92.85% 94.82% 68, 94, 29
aform/src/components/form/AFieldset.vue 88.88% 100% 50% 88.88% 8
aform/src/components/form/AFileAttach.vue 0% 0% 0% 0% 26-17
aform/src/components/form/ANumericInput.vue 100% 100% 100% 100%
aform/src/components/form/ATextInput.vue 100% 100% 100% 100%
aform/src/components/utilities/Login.vue 87.5% 88.88% 100% 87.5% 76-78
aform/src/directives/mask.ts 84.09% 59.09% 100% 83.72% 46-47, 54, 69, 91, 131, 136
Generated in workflow #553 for commit 93bd0e9 by the Vitest Coverage Report Action

@Alchez Alchez changed the title feat: adropdown edited [aform] add adropdown features Jan 13, 2025
Copy link
Collaborator

@Alchez Alchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lauty95 I think the dropdown should return all possible results when clicked, but I'm only seeing the selected value (the test failure might be related too).

@lauty95 lauty95 self-assigned this Jan 13, 2025
@lauty95
Copy link
Collaborator Author

lauty95 commented Jan 16, 2025

@lauty95 I think the dropdown should return all possible results when clicked, but I'm only seeing the selected value (the test failure might be related too).

I changed the onFocus event to display all possible results when clicked.
I also updated some tests because I changed the way asynchronous functions are called.
However, I still see the tests failing due to this error: "ERROR: Coverage for branches (66.66%) does not meet the global threshold (70%)".

@lauty95 lauty95 requested a review from Alchez January 16, 2025 15:28
Copy link
Collaborator

@Alchez Alchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I still see the tests failing due to this error: "ERROR: Coverage for branches (66.66%) does not meet the global threshold (70%)".

@lauty95 This is fine to ignore. As we add more tests, that number should go beyond the threshold.

@Alchez Alchez merged commit b9d06b7 into development Jan 20, 2025
4 of 5 checks passed
@Alchez Alchez deleted the fix-adropdown branch January 20, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants