Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stonecrop] update vue to 3.5 + other deps #153

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

Alchez
Copy link
Collaborator

@Alchez Alchez commented Sep 18, 2024

@Alchez Alchez requested a review from agritheory September 18, 2024 10:59
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Coverage Report for ./aform

Status Category Percentage Covered / Total
🟢 Lines 87.01% (🎯 70%) 201 / 231
🟢 Statements 86.44% (🎯 70%) 204 / 236
🟢 Functions 80.76% (🎯 70%) 42 / 52
🔴 Branches 68.8% (🎯 70%) 75 / 109
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
aform/src/components/AForm.vue 90% 40% 85.71% 90% 40-42, 41
aform/src/components/form/ACheckbox.vue 100% 100% 100% 100%
aform/src/components/form/ADate.vue 85.71% 50% 100% 85.71% 38
aform/src/components/form/ADatePicker.vue 96.61% 90.9% 92.85% 96.49% 66, 28
aform/src/components/form/ADropdown.vue 91.48% 76.92% 84.61% 91.48% 55, 84-85, 93
aform/src/components/form/AFieldset.vue 87.5% 100% 50% 87.5% 8
aform/src/components/form/AFileAttach.vue 0% 0% 0% 0% 26, 28-30, 29, 32, 32, 2, 1, 8-9, 14, 17
aform/src/components/form/ANumericInput.vue 100% 100% 100% 100%
aform/src/components/form/ATextInput.vue 100% 100% 100% 100%
aform/src/components/utilities/Login.vue 87.5% 88.88% 100% 87.5% 76-78
Unchanged Files
aform/src/components/base/CollapseButton.vue 100% 100% 100% 100%
aform/src/components/form/AComboBox.vue 0% 0% 100% 0% 2-1
aform/src/directives/mask.ts 84.09% 59.09% 100% 83.72% 33-34, 41, 50, 65, 98, 103
Generated in workflow #325

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Coverage Report for ./beam

Status Category Percentage Covered / Total
🔴 Lines 11.11% (🎯 70%) 7 / 63
🔴 Statements 12.12% (🎯 70%) 8 / 66
🔴 Functions 5.26% (🎯 70%) 1 / 19
🔴 Branches 0% (🎯 70%) 0 / 31
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
beam/src/components/ItemCheck.vue 0% 0% 0% 0% 11, 15, 17-19, 18, 2, 1
beam/src/components/ItemCount.vue 0% 0% 0% 0% 18, 31, 33-38, 34-37, 40-42, 41, 2, 1
beam/src/components/ListAnchor.vue 0% 100% 100% 0% 1
beam/src/components/ListItem.vue 0% 0% 0% 0% 37, 3, 2-1, 10, 14
Unchanged Files
beam/src/components/ActionFooter.vue 0% 100% 0% 0% 12, 14-16, 15, 2-3
beam/src/components/BeamModal.vue 0% 0% 0% 0% 3, 2-1, 4-5, 5
beam/src/components/BeamModalOutlet.vue 0% 100% 100% 0% 2
beam/src/components/Confirm.vue 0% 0% 0% 0% 4-5
beam/src/components/ListView.vue 0% 0% 0% 0% 36, 38-40, 39, 42-44, 43, 46-52, 47-51, 50, 2, 6-null
beam/src/components/Navbar.vue 0% 0% 0% 0% 15, 17-19, 18, 2, 6, 5-4, 8-null
beam/src/components/ScanInput.vue 88.88% 100% 50% 87.5% 26
Generated in workflow #325

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Coverage Report for ./atable

Status Category Percentage Covered / Total
🟢 Lines 74.39% (🎯 70%) 122 / 164
🟢 Statements 73.96% (🎯 70%) 125 / 169
🟢 Functions 72.72% (🎯 70%) 24 / 33
🔴 Branches 48.48% (🎯 70%) 64 / 132
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
atable/src/components/ACell.vue 94.82% 56.75% 100% 94.82% 70, 110-113, 164
atable/src/components/AExpansionRow.vue 0% 0% 0% 0% 36-37, 40-42, 41, 44-63, 45-51, 47-49, 53-55, 54, 57-62, 1, 3
atable/src/components/ARow.vue 61.9% 57.14% 60% 61.9% 52, 59, 63, 67, 69-74, 70-73, 76-81, 12
atable/src/components/ATable.vue 88% 46.15% 100% 91.3% 156-158, 157, 157
atable/src/components/ATableHeader.vue 100% 50% 100% 100%
atable/src/components/ATableModal.vue 50% 100% 0% 50% 29
Unchanged Files
atable/src/components/index.ts 65.9% 50% 66.66% 66.66% 47-49, 48, 61, 84-86, 85, 104-116, 105-113, 106-112, 108-111, 110, 114-116, 115
Generated in workflow #325

Copy link
Owner

@agritheory agritheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, it'll be nice to have these performance improvements. There aren't any concerns with changes to Vue.

@agritheory agritheory marked this pull request as ready for review September 18, 2024 15:25
@agritheory agritheory merged commit dfaced1 into development Sep 18, 2024
4 of 7 checks passed
@agritheory agritheory deleted the fix-deps-1 branch September 18, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants