Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce navbar height, remove icon, made sticky navbar #147

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

crabinak
Copy link
Collaborator

@agritheory I made the updates outlined in #146 . It looks like the navbar is full width to me, but let me know if you are still seeing that issue.

I had to add a workaround on one of the Histoire wrapper classes as overflow:auto breaks the position:sticky functionality of children elements. I put this in the beam.css file and it shouldn't cause any conflicts since the Histoire class name is targets is hyper specific.

beam-navbar-fix

@crabinak crabinak requested a review from agritheory September 10, 2024 15:44
@agritheory
Copy link
Owner

@crabinak Looks great, thank you !

@agritheory agritheory merged commit 3f65d95 into development Sep 13, 2024
6 checks passed
@Alchez Alchez deleted the beam-navbar-improvements branch November 19, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants