-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aform, atable] update test coverage for Stonecrop packages #117
Conversation
@agritheory This PR switches the Vitest reporter from v8 to istanbul. For building the coverage report, Vitest defaults to the v8 reporter. Unfortunately, v8's AST considers things like On the other hand, the istanbul reporter has much finer control over what counts as coverage, and it seems to report general coverage better as well. Additionally, the docs over at v8 says that they're trying to integrate the reporter's coverage information into istanbul as well. |
83dcaa6
to
2e8753c
Compare
Coverage Report for ./atable
File Coverage
|
Coverage Report for ./aform
File Coverage
|
@agritheory, the aform application code was pretty useful to test with Vitest since it's all isolated components with unique functions that can be tested headlessly. However, I'm writing atable tests and I'm wondering if those are better suited to be written in a non-headless, browser framework Cypress or WebdriverIO. This is mostly because the components are coupled and there's a lot of visual assertions to be possibly made on the components based on the usage options (and Istanbul/v8 are erratic with coverage on child components). What do you think? |
Closes #108.
Todo: