Fix the idiosyncratic "no atoms??" error message. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Lua error appears if the atoms argument to pd.Class:outlet is anything but a table. The fix is trivial: Check that the atoms argument actually is a table, and, if this is not the case, either output a more helpful error message, or just turn the singleton into a table with one element (which is what we do here). I'm not sure that I actually want to fix this. It's one of pdlua's lovely quirks which I actually discuss in the tutorial in order to illustrate what happens if something goes wrong deep down in pdlua's internals.
agraef
force-pushed
the
master
branch
3 times, most recently
from
5a45e7e
to
aa822ad
Compare
|
Well, "no atoms??" is no more, it has been replaced by much better error reporting. But the error could still be avoided by this changeset, so I'm keeping the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Lua error appears if the atoms argument to pd.Class:outlet is anything but a table. The fix is trivial: Check that the atoms argument actually is a table, and, if this is not the case, either output a more helpful error message, or just turn the singleton into a table with one element (which is what we do here).
I'm not sure that I actually want to fix this. It's one of pdlua's funny quirks which I actually discuss in the tutorial in order to illustrate what happens if something goes wrong deep down in pdlua's internals.