Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP whitespace and indentation #21

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP whitespace and indentation #21

wants to merge 1 commit into from

Conversation

erights
Copy link

@erights erights commented Nov 18, 2019

DO NOT MERGE: Based on an ancient master

An experiment in whitespace layout for grammar definition. Only approve if you like it better,

@erights erights requested a review from michaelfig November 18, 2019 02:17
@erights
Copy link
Author

erights commented Nov 18, 2019 via email

@michaelfig
Copy link
Collaborator

Thanks, I do like the sentiment of the change.

Unfortunately, the lib/*.js files are generated by ./build.bat from the lib/*.js.ts files, and because of the type annotations in the *.js.ts files, your changes don't apply cleanly to them.

Let's revisit this when we have time to format the grammars in the *.js.ts files better.

@erights erights marked this pull request as draft September 18, 2021 02:04
@erights
Copy link
Author

erights commented Sep 18, 2021

Let's revisit this when we have time to format the grammars in the *.js.ts files better.

Converted to Draft

@erights erights changed the title whitespace and indentation WIP whitespace and indentation May 20, 2023
@erights erights removed the request for review from michaelfig July 6, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants