-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore memory #1975
Open
jeffbryner
wants to merge
10
commits into
agno-agi:main
Choose a base branch
from
jeffbryner:firebase_memory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Firestore memory #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you please add a corresponding cookbook and add the steps to setup firestore and get the required env variables at the top of the cookbook? |
Hi @manthanguptaa I've added the cookbook |
cookbook/agent_concepts/memory/09_persistent_memory_firestore.py
Outdated
Show resolved
Hide resolved
arrange imports Co-authored-by: Manthan Gupta <[email protected]>
@manthanguptaa I've updated this to sync with agno 1.1.13 and resolve comments. Can you review when you have a moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds firestore memory to solve #1974
Fixes # (issue)
[Feature Request] firestore agent memory #1974
Type of change
Checklist
./scripts/format.sh
and./scripts/validate.sh
to ensure code is formatted and linted.Additional Notes
firestore works best without having to create indexes. The data model collection_name/user_id/memories allows for selecting all memories and using an orderby without having to create a composite index which is a bit tricky in firestore (requires async calls, no callback when completed, not ready immediately).