Skip to content

Commit

Permalink
chore: add ruff necessity in PR template (#168)
Browse files Browse the repository at this point in the history
  • Loading branch information
dongyuanjushi authored Jul 12, 2024
1 parent d937e8d commit a6d05fe
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
9 changes: 7 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
Thank you for your contribution to AIOS! Before submitting the pull request, please ensure the PR meets the following criteria. This helps improve the efficiency of the review process.
Thank you for your contribution to AIOS!
Before submitting the pull request, please ensure **the PR meets the following criteria**! This helps improve the efficiency of the review process.

### Code Quality
Before submitting your PR, you need to follow the steps below to maintain code quality.
- Use `pip install -r requirements-dev.txt` to install the extra dependencies in requirements-dev.txt for the following checks.
- Use `pre-commit install` to install pre-commit locally before you commit messages. The pre-commit can help correct the style that are added or modified.

### PR title and classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately (i.e., "prefix: description") to indicate the type of change. Please use one of the prefixs as below:
Expand All @@ -17,7 +23,6 @@ Only specific types of PRs will be reviewed. The PR title is prefixed appropriat
- **Issue:** the issue # it fixes, if applicable
- **Dependencies:** any dependencies required for this change


### For the Reviews
- After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
- If no one reviews your PR within a few days, please @-mention one of [dongyuanjushi](https://github.com/dongyuanjushi/), [evison](https://github.com/evison), [BRama10](https://github.com/BRama10), [JHSUYU](https://github.com/JHSUYU), [WujiangXu](https://github.com/WujiangXu), [MingyuJ666](https://github.com/MingyuJ666), [xizhu1022](https://github.com/xizhu1022).
5 changes: 2 additions & 3 deletions runtime/exec.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,8 @@ def stop_server():

if __name__ == "__main__":
start_server()

# Example: Stop the server after 10 seconds
import time
time.sleep(10)

stop_server()
stop_server()
2 changes: 0 additions & 2 deletions runtime/server.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from starlette.requests import Request
from fastapi import FastAPI
from fastapi.middleware.cors import CORSMiddleware

Expand All @@ -19,4 +18,3 @@ async def run_agent(*args, **kwargs):
@app.get("/get_all_agents")
async def get_all_agents(*args, **kwargs):
pass

0 comments on commit a6d05fe

Please sign in to comment.