Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field alias - first try #146

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hyperiongeo
Copy link

Matt

I creates this PR for you to check out what I have done to date. I'm not entirely sure that is what you were looking for but it covers what I was thinking. This is meant to be a prelim version as there is still a bunch of commented code left behind.

The biggest challenge was dealing with the two mnemonic case, ie the DREF/EREF example (there are two more that I created).

I also created the field_alias param as part of the from_las/from_lasio methods. However, it would entirely replace the existing location dict , rather than adding or appending to the existing. Not sure if that is a good ides or not. I didnt add the "strict" option yet as I wanted your feedback first.

This PR passed all unit tests.

Let me know what you think.

Corey Hooge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant