Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/236/student side notifications #305

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

nadamels
Copy link
Contributor

@nadamels nadamels commented Dec 1, 2023

No description provided.

@hasiburratul
Copy link
Contributor

  • I suggest minimizing the need to hit the server for notifications.
  • The notification overlay currently displays all the action-required issues. You should consider displaying only the most relevant notifications to avoid clutter.
  • Please revert the recent change that passed the NetID to the navbar. This change caused the navbar to display the NetID instead of the user's name. We should maintain consistency by displaying the user's name in the navbar.
  • Consider adding an extra prop to pass the total number of action-required items from the dashboard to the navbar for notification

@hasiburratul hasiburratul merged commit dfd3e7e into master Dec 5, 2023
2 checks passed
@hasiburratul hasiburratul deleted the task/236/student-side-notifications branch December 6, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants