Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new changes to admin dashboard #297

Closed
wants to merge 1 commit into from

Conversation

Tauke190
Copy link
Contributor

Things fixed in this PR

4 task is done in one PR

File Attachments for Issues - Admin Side
Handle null case for comments Admin side
The comments dont show up on the admin side after adding ( Have to reload )
Styling of the admin issues side and department selection

@hasiburratul
Copy link
Contributor

DM'ed

@swostikpati swostikpati self-requested a review November 30, 2023 06:56
@swostikpati
Copy link
Contributor

Some things I observed:

  • The multer on the admin side is not configured (the implementation is already on the student backend side - reach out to me or @nadamels if you need help). Whenever a new file is uploaded, it is not enough just to store the filename in the db (this is definitely required though). The main thing is to use multer (like it is being used on the create request), to actually put the file up on the "uploads" directory (automatically managed by Multer) like this:
    image

  • The files while being stored in the uploads directory should have the date and time added like this (a ss of how the filename looks when it is uploaded from the frontend:
    image

  • Following on the above point, even though we append the date and time while storing the file using multer and the filename in the db (to make the file names unique and secure), we need to remove them while displaying. So here, only the filename (Without the date time) should be visible:
    image

  • For some reason there is always an blank update:
    image
    I am not sure if @hasiburratul is handling it

  • Since we are finalizing on the aspects of the design, make the overflow (only inside this container not globally) auto. This way, the scrollbar will only be visible when there is a requirement for it:
    image

  • I understand you removed the colors from the priority and status tags, but personally I feel that they serve as purposes beyond just mere design. Color coding the tags enables the user to make choices intuitively just on the basis of the mappings (which is a very powerful design tool). They know that "Red" is always going to be high priority, so they won't spend a single second reading through the options to make sure that it says High Priority. This enhances efficiency in a fast-paced work environment such as this. It also reaffirms their selection. I belive the colors should be brought back, they can surely be made a little more subtle (if required) or used as the outline or text color (we can discuss these options):
    image

  • This side looks a little cramped, can you change the flex weights to give a little more area to the right side of the screen:
    image

  • The page needs to be opened in a new tab, but this feature doesn't need to be implemented within this PR, can be done as a separate spike

@Tauke190 Tauke190 closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants