Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/48/design create request view #112

Closed
wants to merge 12 commits into from

Conversation

nadamels
Copy link
Contributor

Submit button
Lint errors fixed
close button added

@swostikpati
Copy link
Contributor

When merge conflicts were fixed, current code in the main branch wasn't integrated properly. So many of the current features were removed completely form the student dashboard. Lint warnings still persist.
image

image

image

@swostikpati
Copy link
Contributor

image

@@ -1,19 +1,15 @@
import { useState, useEffect, useRef } from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this?

import { Link } from "react-router-dom";
import "./StudentDashboard.css";
import StudentNavbar from "../../components/student/StudentNavbar/StudentNavbar";
import StudentViewFilter from "../../components/student/StudentViewFilter/StudentViewFilter";
import DesktopIssueDetails from "../../components/student/StudentIssueOverlay/DesktopIssueDetails";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

@@ -83,33 +80,6 @@ const StudentDashboard = () => {
}
};

// Ref for the overlay div
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole part of the code implemented the issue overlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants