consider the situation when the currentuser is the paidby but not the…

… participant

front-end/src/components/Event.js

@@ -52,27 +52,35 @@ const Event = (props) => {
       const isParticipant = expense.splitDetails.find(
         (detail) => detail.user === userId
       );
-      //let settlement;
       let userBalance = 0;
-
-      if (isParticipant) {
-        if (expense.paidBy === userId) {
+
+      if (expense.paidBy === userId) {
+        // Check if the currentUser is involved in the split
+        if (isParticipant) {
           expense.splitDetails.forEach((split) => {
             if (!split.settlement.status) {
               userBalance += split.settlement.amount;
             }
           });
         } else {
-          //user is not the one who paid, find what the user owe to the person who paid
-          const user = expense.splitDetails.find(
-            (split) => split.user === userId
-          );
-          if (user) {
-            userBalance = user.settlement.status ? 0 : -user.settlement.amount;
-          }
+          let totalSettledAmount = 0;
+          expense.splitDetails.forEach((split) => {
+            if (split && split.settlement && split.settlement.status) {
+              totalSettledAmount += split.settlement.amount;
+            }
+          });
+          userBalance = (expense.totalAmount ? expense.totalAmount : 0) - totalSettledAmount;
+      }
+      } else if (isParticipant) {
+        // If currentUser is not the one who paid, but is involved in the split
+        const user = expense.splitDetails.find(
+          (split) => split.user === userId
+        );
+        if (user) {
+          userBalance = user.settlement.status ? 0 : -user.settlement.amount;
         }
       } else {
-        // User is not a participant, create a settlement object with amount 0
+        // User is neither the payer nor a participant in the split
         userBalance = 0;
       }
 

front-end/src/components/Expense.jsx

@@ -79,17 +79,33 @@ function Expense({ isDarkMode }) {
       (split) => split.user._id === userId
     );
 
-    if (!isParticipant) {
-      // If not a participant, return an empty array or another appropriate value
-      return [];
-    }
-
     let filteredExpenses = [];
 
     if (expensesData.paidBy._id === userId) {
-      filteredExpenses = expensesData.splitDetails.filter(split => split.user._id !== userId).map(split => ({ ...split, displayName: split.user.username, amount: split.settlement.amount}));
-    } else {
-      filteredExpenses = expensesData.splitDetails.filter(split => split.user._id === userId && expensesData.paidBy !== userId).map(split => ({ ...split, displayName: expensesData.paidBy.username, amount: -split.settlement.amount}));;
+      if (!isParticipant) {
+        // If currentUser is not a participant, then the amount will be negative (owed by others)
+        filteredExpenses = expensesData.splitDetails.map(split => ({
+          ...split,
+          displayName: split.user.username,
+          amount: -split.settlement.amount
+        }));
+      } else {
+        // If currentUser is also a participant
+        filteredExpenses = expensesData.splitDetails.filter(split => split.user._id !== userId).map(split => ({
+          ...split,
+          displayName: split.user.username,
+          amount: split.settlement.amount
+        }));
+      }
+    } else if (isParticipant) {
+      // When currentUser is not the one who paid but is a participant
+      filteredExpenses = expensesData.splitDetails.filter(split => split.user._id === userId && expensesData.paidBy !== userId).map(split => ({
+        ...split,
+        displayName: expensesData.paidBy.username,
+        amount: -split.settlement.amount
+      }));
+    }else{
+      filteredExpenses = [];
     }
     return filteredExpenses;
   };