Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vlc,ffmpeg PREFERRED_PROVIDER #1340

Merged

Conversation

EasyIP2023
Copy link
Contributor

- What I did

Switch to defaulting to OE core ffmpeg &
meta-openembedded vlc.

- Reason

Upgrades to newer rpi-distro VLC version
in an OE environment have proven to be
tedious due to all the PI foundation patches.

Some patches aren't fully pushed into github
and require updates to build.

Maintaining patches have also proven to be unstable.

Default to stable builds of both so that peoples
builds aren't broken.

If rpi-distro version of ffmpeg & vlc wanted
users may switch by setting PREFFERED_PROVIDER.

- How I did it

@kraj @agherzan .

What do you guys think?

@EasyIP2023 EasyIP2023 force-pushed the feature/update-vlc-ffmpeg-provider branch 3 times, most recently from 9ba1f74 to ad757b3 Compare June 19, 2024 02:15
Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this. @kraj ?

@EasyIP2023 EasyIP2023 force-pushed the feature/update-vlc-ffmpeg-provider branch from ad757b3 to 9573256 Compare August 20, 2024 02:42
@EasyIP2023
Copy link
Contributor Author

@kraj Any status

Copy link
Collaborator

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this patches. We need to list what we lose/gain by doing the switch, can you add few lines to the docs ?

@agherzan
Copy link
Owner

@kraj what do you mean by docs? Git log or readthedocs? If the latter, I think the commit already adds information about that.

@kraj
Copy link
Collaborator

kraj commented Aug 20, 2024

@kraj what do you mean by docs? Git log or readthedocs? If the latter, I think the commit already adds information about that.

the same .md file in the PR, which mentions about preferred providers.

@agherzan
Copy link
Owner

@kraj Could you have an in-line text proposal? Just to make sure we are aligned on what you propose here.

@kraj
Copy link
Collaborator

kraj commented Aug 21, 2024

@kraj Could you have an in-line text proposal? Just to make sure we are aligned on what you propose here.

Yeah will send separately merge this one

@agherzan agherzan enabled auto-merge (rebase) August 28, 2024 13:13
Switch to defaulting to OE core ffmpeg &
meta-openembedded vlc.

Upgrades to newer rpi-distro VLC version
in an OE environment have proven to be
tedious due to all the PI foundation patches.

Some patches aren't fully pushed into github
and require updates to build.

Maintaining patches have also proven to be unstable.

Defualt to stable builds of both so that.

Peoples builds aren't broken. If rpi-distro
rpi-distro version of ffmpeg & vlc wanted
users may switch by setting PREFFERED_PROVIDER.

Signed-off-by: Vincent Davis Jr <[email protected]>
auto-merge was automatically disabled August 29, 2024 01:17

Head branch was pushed to by a user without write access

@EasyIP2023 EasyIP2023 force-pushed the feature/update-vlc-ffmpeg-provider branch from 9573256 to faea953 Compare August 29, 2024 01:17
Copy link
Collaborator

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@agherzan agherzan merged commit 43dada0 into agherzan:master Sep 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants